[Piglit] [PATCH] request RGB visual, fixes gbm rendering

[Chad Versace]

On Tue 12 May 2015, Ilia Mirkin wrote:
> On Tue, May 12, 2015 at 1:13 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > On 9 May 2015 at 08:08, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> >> GBM presumably defaults to RGB565 otherwise. Not all of these are
> >> required, as some would still work with less precision, but this makes
> >> the tests consistent. At least fp-formats and user-clip were failing
> >> previously.
> >>
> > You're spot on - waffle gbm does default to RGB565 when the
> > red/green/blue/alpha size is zero (the default values set in
> > piglit_winsys_framework.c). Although I'm a bit baffled by the meaning
> > of PIGLIT_GL_VISUAL_RGB - does it imply a 32bit and/or a red_size =
> > green_size = blue_size(d) visual ?
> 
> No idea... it just says "1". 1 byte? 1 bit? No idea. But it works :)
> 
>         if (test_config->window_visual &
>             (PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_RGBA)) {
>                 attrib_list[i++] = WAFFLE_RED_SIZE;
>                 attrib_list[i++] = 1;
>                 attrib_list[i++] = WAFFLE_GREEN_SIZE;
>                 attrib_list[i++] = 1;
>                 attrib_list[i++] = WAFFLE_BLUE_SIZE;
>                 attrib_list[i++] = 1;
>         }

It means 1 *bit*, just as it does in GLX and EGL attribute lists.