[Piglit] [PATCH] framework/run.py: allow additional excluded tests on resume

Dylan Baker baker.dylan.c at gmail.com
Tue May 19 09:41:57 PDT 2015

On Tue, May 19, 2015 at 12:06:54PM +0200, Daniel Vetter wrote:
> On Mon, May 18, 2015 at 05:12:17PM -0700, Dylan Baker wrote:
> > I'm not sure this is a good idea,
> > 
> > Ken Graunke and I talked this to death when I did the refactor that
> > split the run and resume code into separate paths, and we agreed that
> > changing the tests during a resume would make it impossible to reproduce
> > a run, since the regex you pass might exclude tests that have already
> > completed.
> > 
> > That said, I'm opened to being convinced it is a good idea.
> With your patches to mark a test as incomplete, should we instead just
> have an option on resume to mark all incomplete tests as failed and not
> try to restart them? Or is that already what happens (tbh I haven't
> tried).
> -Daniel

Currently they're always retried. It seems reasonable to me to either
change the behavior or add a switch to change the behavior to either
mark them as failed or just leave them as incomplete.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150519/98635750/attachment.sig>

More information about the Piglit mailing list