[Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

[Timothy Arceri]

On Tue, 2015-10-27 at 15:34 +0000, Emil Velikov wrote:
> Hi all,

Hi Emil,

A few comments:

- Patches 1-4 all have extra whitespace

- Your a bunch or your tests require the extension and also the glsl verion to
be 4.30 where we know the extension will exist. You should instead change the
glsl version to the lowest version that the extension requires otherwise these
test will not be run on Mesa until a driver enables 4.30.

- I've made some additional comments on patch 3 and 5

- Change the check_link to true in patches 3 and 4 and then you can add to the
 all the commit messages something like:
Test results:
Nvidia GeForce 840M -
NVIDIA 352.41: pass


> 
> Some update over the previous round
>  - Add the missing S in enhanced-layouts :)
>  - The uniform tests are prefixed with UBO.
>  - SSBO tests are added in the respective hunks.
>  - The final (negative link) test has been added.
> 
> Note: all of these are written based on the spec alone and haven't been 
> verified against existing OpenGL implementations (the official NVIDIA 
> driver does not play well on my ageing laptop).
> 
> Please review, bikeshed and/or flame away.
> 
> Thanks,
> Emil
> 
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit