[Piglit] [PATCH 3/5] arb_enhanced_layouts: test some more compile time constant features

Timothy Arceri timothy.arceri at collabora.com
Sun Nov 1 19:04:43 PST 2015


On Sun, 2015-11-01 at 21:50 -0500, Ilia Mirkin wrote:
> On Sun, Nov 1, 2015 at 9:48 PM, Timothy Arceri
> <timothy.arceri at collabora.com> wrote:
> > > > --- /dev/null
> > > > +++ b/tests/spec/arb_enhanced_layouts/compiler/compiler-time
> > > > -constants/input-location-glsl-330.vert
> > > > @@ -0,0 +1,16 @@
> > > > +// [config]
> > > > +// expect_result: pass
> > > > +// glsl_version: 3.30
> > > 
> > > 1.40 (and you also need GL_ARB_explicit_attrib_location) -- or is 3.30
> > > somehow different? Don't think that it is...
> > 
> > 3.30 includes GL_ARB_explicit_attrib_location
> 
> I know, but why are you testing with glsl 3.30? What's wrong with
> 1.40? There presumably are tests that make sure that the layouts are
> auto-enabled in glsl 3.30...

Yeah right, there is already a test for 1.40, I don't recall why I added this
specific test but it does look like I should drop it as its testing
ARB_explicit_attrib_location rather than enhanced layouts.



More information about the Piglit mailing list