[Piglit] [PATCH 06/15] arb_direct_state_access: Testing CopyNamedBufferSubData.

Martin Peres martin.peres at linux.intel.com
Mon Nov 2 01:14:43 PST 2015


On 01/11/15 03:15, Ilia Mirkin wrote:
> What happened here? There are no references to NamedBuffer* in piglit.

Darn it, the series indeed never landed... Laura, can you remember why?
Was it only due to the shortage of time before moving on to another project?

In any case, I should have followed up on this :s

Martin

>
> On Wed, Apr 1, 2015 at 7:52 AM, Martin Peres
> <martin.peres at linux.intel.com> wrote:
>> On 23/01/15 21:03, Laura Ekstrand wrote:
>>> ---
>>>    tests/spec/arb_direct_state_access/namedbufferstorage.c | 7 +------
>>>    1 file changed, 1 insertion(+), 6 deletions(-)
>>>
>>> diff --git a/tests/spec/arb_direct_state_access/namedbufferstorage.c
>>> b/tests/spec/arb_direct_state_access/namedbufferstorage.c
>>> index 6630467..c68bc27 100644
>>> --- a/tests/spec/arb_direct_state_access/namedbufferstorage.c
>>> +++ b/tests/spec/arb_direct_state_access/namedbufferstorage.c
>>> @@ -218,15 +218,10 @@ read_subtest(GLboolean coherent, GLboolean
>>> client_storage)
>>>          glClear(GL_COLOR_BUFFER_BIT);
>>>          glCreateBuffers(1, &srcbuf);
>>>          glNamedBufferData(srcbuf, BUF_SIZE, array, GL_STATIC_DRAW);
>>> -       glBindBuffer(GL_COPY_READ_BUFFER, srcbuf);
>>>          /* Copy some data to the mapped buffer and check if the CPU can
>>> see it. */
>>> -       glBindBuffer(GL_COPY_WRITE_BUFFER, buffer);
>>> -       glCopyBufferSubData(GL_COPY_READ_BUFFER, GL_COPY_WRITE_BUFFER,
>>> -                           0, 0, BUF_SIZE);
>>> +       glCopyNamedBufferSubData(srcbuf, buffer, 0, 0, BUF_SIZE);
>>>    -     glBindBuffer(GL_COPY_READ_BUFFER, 0);
>>> -       glBindBuffer(GL_COPY_WRITE_BUFFER, 0);
>>>          glDeleteBuffers(1, &srcbuf);
>>>          if (!coherent)
>> Same as patch 4.
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit



More information about the Piglit mailing list