[Piglit] [PATCH 5/5] arb_enhanced_layouts: invalid compile time constant types

[Emil Velikov]

On 2 November 2015 at 01:54, Timothy Arceri
<timothy.arceri at collabora.com> wrote:
> ---
>  .../invalid-types/bool.vert                        | 23 ++++++++++++++++++++++
>  .../invalid-types/float.vert                       | 23 ++++++++++++++++++++++
>  .../invalid-types/vec2.vert                        | 23 ++++++++++++++++++++++
>  .../invalid-types/vec3.vert                        | 23 ++++++++++++++++++++++
>  .../invalid-types/vec4.vert                        | 23 ++++++++++++++++++++++
>  5 files changed, 115 insertions(+)
>  create mode 100644 tests/spec/arb_enhanced_layouts/compiler/compiler-time-constants/invalid-types/bool.vert
>  create mode 100644 tests/spec/arb_enhanced_layouts/compiler/compiler-time-constants/invalid-types/float.vert
>  create mode 100644 tests/spec/arb_enhanced_layouts/compiler/compiler-time-constants/invalid-types/vec2.vert
>  create mode 100644 tests/spec/arb_enhanced_layouts/compiler/compiler-time-constants/invalid-types/vec3.vert
>  create mode 100644 tests/spec/arb_enhanced_layouts/compiler/compiler-time-constants/invalid-types/vec4.vert
>
> diff --git a/tests/spec/arb_enhanced_layouts/compiler/compiler-time-constants/invalid-types/bool.vert b/tests/spec/arb_enhanced_layouts/compiler/compiler-time-constants/invalid-types/bool.vert
> new file mode 100644
> index 0000000..2eb8761
> --- /dev/null
> +++ b/tests/spec/arb_enhanced_layouts/compiler/compiler-time-constants/invalid-types/bool.vert
> @@ -0,0 +1,23 @@
> +// [config]
> +// expect_result: fail
> +// glsl_version: 1.10
> +// require_extensions: GL_ARB_enhanced_layouts GL_ARB_explicit_attrib_location
> +// [end config]
> +//
> +// Tests that only integral constant expression can be used.
> +//
> +// Section 4.3.3 (Constant Expressions) from the GLSL 4.50 spec:
> +// "An integral constant expression is a constant expression that evaluates to
> +//  a scalar signed or unsigned integer."
> +
> +#version 110
Perhaps bump the version to 1.40 here and throughout the patch ?

Either way with the s/compiler/compile/ change in the location (same
goes for 4/5)
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil