[Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

[Emil Velikov]

Hi Tim, all

On 2 November 2015 at 16:20, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 1 November 2015 at 22:53, Timothy Arceri
> <timothy.arceri at collabora.com> wrote:

>> - Change the check_link to true in patches 3 and 4 and then you can add to the
>>  all the commit messages something like:
>> Test results:
>> Nvidia GeForce 840M -
>> NVIDIA 352.41: pass
>>
> These actually puzzle me quite a bit. The spec is quite clear that
> those should be a compile-time errors. By setting the check_link,
> we'll be doing a link-time check. Should we ignore the Nvidia's driver
> behaviour, or just toggle it on and add a note "this should really be
> off, as we want to do a compile-time check" like note ?
>
Can people cast their 2c on the above topic ? Currently we have some
~180 'compile' tests which resort to link checking. From a quick look
I cannot see any comments/justification - did those fall victims of
copy/paste or it's deliberate.

Perhaps we should pick our favourite and document it ?

Thanks
Emil