[Piglit] [PATCH 1/2] arb_shader_stencil_export: move to standard location

[Emil Velikov]

Hi Ben,

Please feed these through -M so that git can detect the code movement.
Otherwise people start running away :P

But seriously, just a small comment below.

On 23 October 2015 at 06:00, Ben Widawsky <benjamin.widawsky at intel.com> wrote:

> --- /dev/null
> +++ b/tests/spec/arb_shader_stencil_export/glsl-fs-shader-stencil-export.c

> +enum piglit_result
> +piglit_display(void)
> +{
> +       GLboolean pass = GL_TRUE;
> +       float p[4];
> +
> +       glClearColor(0.5, 0.5, 0.5, 0.5);
> +       glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT);
> +
> +       glEnable(GL_STENCIL_TEST);
> +       glStencilOp(GL_REPLACE, GL_REPLACE, GL_REPLACE);
> +
> +       piglit_draw_rect(-1, -1, 2, 2);
> +
> +       glReadPixels(0, 0, 3, 1, GL_STENCIL_INDEX, GL_FLOAT, p);

The original test uses rect(0, 0 piglit_width, piglit_height) +
ortho_projection. As you've changed the former and dropped the latter
the glReadPixels() should be updated as well ?

You'd also need to update all.py. Currently it will attempt to run the
old, missing test. Something like

diff --git a/tests/all.py b/tests/all.py
index c28ae2b..03ee52e 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -508,7 +508,6 @@ with profile.group_manager(PiglitGLTest, 'shaders') as g:
    g(['glsl-fs-pointcoord'])
    g(['glsl-fs-raytrace-bug27060'])
    g(['glsl-fs-sampler-numbering'])
-    g(['glsl-fs-shader-stencil-export'])
    g(['glsl-fs-sqrt-branch'])
    g(['glsl-fs-texturecube'])
    g(['glsl-fs-texturecube', '-bias'], 'glsl-fs-texturecube-bias')
@@ -2551,6 +2550,10 @@ with profile.group_manager(
        'GL_DEPTH32F_STENCIL8', 0)

with profile.group_manager(
+        PiglitGLTest, grouptools.join('spec',
'arb_shader_stencil_export')) as g:
+    g(['glsl-fs-shader-stencil-export'])
+
+with profile.group_manager(

On the really nitpicky side one can rename the test to something
better, but I'm out of ideas :-\

With this (and the similar comment for 2/2) the batch is
Reviewed-by: Emil Velikov <emil.velikov at collabora.co.uk>

-Emil