[Piglit] [PATCH v3 5/5] arb-enhanced-layouts: explicit-offset: add linker test

Emil Velikov emil.l.velikov at gmail.com
Thu Nov 12 05:35:34 PST 2015


On 11 November 2015 at 21:14, Timothy Arceri <t_arceri at yahoo.com.au> wrote:
> On Wed, 2015-11-11 at 18:14 +0000, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> Check if the linker throws an error when the offset across two
>> identically named blocks' members are not the same.
>>
>> v2:
>>  - Rework into intra- and interstage tests (Tim).
>>  - Tweak shader comment (wrong ...)
>>
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>
> These look better now thanks.
>
> Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>
Thanks Tim.

I've addressed all your comments (incl. the s/-/_/ in the extension
name) and pushed these to master.
If you and/or others find anything strange in the patches just reply
inline and I'll map/update accordingly.

Cheers,
Emil


More information about the Piglit mailing list