[Piglit] [PATCH v3 0/4] Use subprocess32 for timeouts

baker.dylan.c at gmail.com baker.dylan.c at gmail.com
Thu Nov 12 14:52:11 PST 2015


From: Dylan Baker <baker.dylan.c at gmail.com>

This is the 3rd revision of my series to use subprocess32 for test
timeouts.

This has some cleanups as requested by Thomas, and a few unittest
problems I noticed are fixed.

The biggest change however is the removal of the mixin for timeouts, and
them being left directly in the base Test class. There are a couple of
reasons for this. First, timeouts are a pretty nice feature, and I
suspect most suites will want them; second it vastly reduces the amount
of code required.

Dylan Baker (4):
  framework/tests: add helper for checking for 3rd party modules
  framework/tests/base_tests.py: fix descriptions of two timeout tests
  framework/tests/base_tests.py: use utils helper to simplify test
  framework/test/base.py: use subprocess32 for timeouts.

 framework/results.py                    |   2 +
 framework/test/base.py                  | 130 ++++++++++++------------------
 framework/tests/base_tests.py           | 135 +++++++++++++++++++++++++++++---
 framework/tests/junit_backends_tests.py |   3 +-
 framework/tests/utils.py                |   9 +++
 tox.ini                                 |  10 ++-
 6 files changed, 188 insertions(+), 101 deletions(-)

-- 
2.6.2



More information about the Piglit mailing list