[Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Nov 17 15:30:35 PST 2015



On 11/17/2015 09:37 PM, Dylan Baker wrote:
> On Tue, Nov 17, 2015 at 04:25:53PM +0100, Samuel Pitoiset wrote:
>> piglit_require_GLSL_version() requires an integer as parameter, not a float.
>> This fixes an implicit conversion spotted by Clang.
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   .../arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c  | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c b/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
>> index ff4b0e0..36b0a2d 100644
>> --- a/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
>> +++ b/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
>> @@ -115,7 +115,7 @@ piglit_init(int argc, char **argv)
>>   	int i;
>>
>>   	/* Set up test */
>> -	piglit_require_GLSL_version(1.50);
>> +	piglit_require_GLSL_version(150);
>>   	piglit_require_transform_feedback();
>>   	piglit_require_extension("GL_ARB_gpu_shader_fp64");
>>
>> --
>> 2.6.2
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit
>
> Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>
>

Seems like I don't have access to push to piglit repository (but it 
works for mesa btw).

Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (13/13), done.
Writing objects: 100% (13/13), 1.40 KiB | 0 bytes/s, done.
Total 13 (delta 11), reused 0 (delta 0)
error: insufficient permission for adding an object to repository 
database ./objects

fatal: failed to write object
error: unpack failed: unpack-objects abnormal exit
To ssh://git.freedesktop.org/git/piglit
  ! [remote rejected] master -> master (n/a (unpacker error))
error: failed to push some refs to 'ssh://git.freedesktop.org/git/piglit'

Can someone have a look at this, please?
Thanks.


More information about the Piglit mailing list