[Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

Emil Velikov emil.l.velikov at gmail.com
Wed Nov 18 08:05:55 PST 2015


On 17 November 2015 at 15:25, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:
> piglit_require_GLSL_version() requires an integer as parameter, not a float.
> This fixes an implicit conversion spotted by Clang.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  .../arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c b/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
> index ff4b0e0..36b0a2d 100644
> --- a/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
> +++ b/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
> @@ -115,7 +115,7 @@ piglit_init(int argc, char **argv)
>         int i;
>
>         /* Set up test */
> -       piglit_require_GLSL_version(1.50);
> +       piglit_require_GLSL_version(150);
I felt bored for a few minutes and had a quick look at the whole of
piglit. This is the only case where we implicitly or explicitly try to
feed an incorrect value (float in this case) into
piglit_require_GLSL_version().

In case anyone is interested :P
-Emil


More information about the Piglit mailing list