[Piglit] [PATCH 3/9] all.py: Everything in MSAA_SAMPLE_COUNTS is already even

Dylan Baker baker.dylan.c at gmail.com
Fri Nov 20 14:14:35 PST 2015


On Thu, Nov 19, 2015 at 08:00:09PM -0800, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> If this test has problems with odd sample counts, the test should detect
> that and SKIP.

I'm not sure I agree. I think it's pretty reasonable for all.py to only
pass valid inputs to a test binary.

> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  tests/all.py | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/all.py b/tests/all.py
> index 1038e07..abe7da2 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -2758,12 +2758,10 @@ with profile.group_manager(
>        'alpha-blending slow_cc')
>      g(['ext_framebuffer_multisample-fast-clear'], 'fast-clear')
>  
> -    for num_samples in MSAA_SAMPLE_COUNTS:
> -        if num_samples % 2 != 0:
> -            continue
> +    for sample_count in (str(x) for x in MSAA_SAMPLE_COUNTS):
>          g(['ext_framebuffer_multisample-alpha-blending-after-rendering',
> -           str(num_samples)],
> -          'alpha-blending-after-rendering {}'.format(num_samples))
> +           sample_count],
> +          'alpha-blending-after-rendering {}'.format(sample_count))
>  
>      for num_samples in ('all_samples', ) + MSAA_SAMPLE_COUNTS:
>          g(['ext_framebuffer_multisample-formats', str(num_samples)],
> -- 
> 2.1.0
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20151120/6123b37c/attachment.sig>


More information about the Piglit mailing list