[Piglit] [PATCH 0/3] Make printing groups more straightforward

baker.dylan.c at gmail.com baker.dylan.c at gmail.com
Fri Nov 20 17:10:00 PST 2015


From: Dylan Baker <baker.dylan.c at gmail.com>

For reasons that are mostly historical at this point, piglit uses '@' as a
group separator internally. Part of the work that allowed this created a
package for dealing with groups strings (grouptools), the replaces '/'
with '@'.

Of course, '@' is much harder to read in a string than '/', the console
summary was later changed to print '/' again.

It really makes sense to separate the two, errr, separators. Thus
piglit's internal representation of groups doesn't bleed over into the
external representation.

This series addresses three problems related to this goal:
1) Add a function that takes a group name delemited with
   rouptools.SEPARATOR (the architecture of grouptools is such that the
   separator can easily be changed for whatever reason)
2) Use this function in the verbose logger
3) allow the -t and -x options to take '/' separated strings.

The only external change related to this series is the verbose logger,
and the extension of the -t and -x options.

Dylan Baker (3):
  framework/grouptools.py: Add a function for print formatting
  framework/log.py: Use grouptools.format in verbose logger.
  framework/options: Handle '/' in -t and -x options

 framework/grouptools.py             | 17 +++++++++++++++++
 framework/log.py                    |  3 ++-
 framework/options.py                | 27 ++++++++++++++++++++++-----
 framework/summary/console_.py       |  2 +-
 framework/tests/grouptools_tests.py |  7 +++++++
 framework/tests/options_tests.py    | 14 ++++++++++++++
 6 files changed, 63 insertions(+), 7 deletions(-)

-- 
2.6.2



More information about the Piglit mailing list