[Piglit] [PATCH V2] arb_separate_shader_objects: test mixed explicit and non-explicit locations

Ilia Mirkin imirkin at alum.mit.edu
Mon Nov 23 15:02:27 PST 2015


On Mon, Nov 23, 2015 at 6:01 PM, Timothy Arceri <t_arceri at yahoo.com.au> wrote:
> On Mon, 2015-11-23 at 17:21 -0500, Ilia Mirkin wrote:
>> On Mon, Nov 23, 2015 at 5:15 PM, Timothy Arceri <t_arceri at yahoo.com.au>
>> wrote:
>> > diff --git a/tests/all.py b/tests/all.py
>> > index e80f3af..3adc503 100644
>> > --- a/tests/all.py
>> > +++ b/tests/all.py
>> > @@ -2160,6 +2160,8 @@ with profile.group_manager(
>> >        'Rendezvous by name')
>> >      g(['arb_separate_shader_object-rendezvous_by_name_interpolation'],
>> >        'Rendezvous by name with multiple interpolation qualifier')
>> > +    g(['arb_separate_shader_object
>> > -mixed_explicit_and_non_explicit_locations', '-fbo'],
>> > +      'Mixed explicit and non-explicit locations', run_concurrent=False)
>>
>> Why non-concurrent? Esp when you're *manually* adding -fbo to it?
>
> Wasn't really thinking about it, just copied from arb_separate_shader_object
> -rendezvous_by_location which is what I based my patch off.
>
> Will fix.

Dylan says that -fbo is added to all concurrent tests, so this should
be unnecessary once you remove run_concurrent=False.


More information about the Piglit mailing list