[Piglit] [PATCH] arb_separate_shader_objects: dont check for INVALID_OPERATION after validation

Tapani Pälli tapani.palli at intel.com
Mon Nov 30 20:43:53 PST 2015


Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

On 12/01/2015 01:31 AM, Timothy Arceri wrote:
> Validation should not generate an INVALID_OPERATION only the draw call should, this
> was seems to have been working around a bug in Mesa.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=93180
> ---
>   tests/spec/arb_separate_shader_objects/active-sampler-conflict.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c b/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c
> index 0a91f49..fbfa957 100644
> --- a/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c
> +++ b/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c
> @@ -226,8 +226,6 @@ test_sampler_conflict(GLuint prog, GLuint pipe,
>   		pass = false;
>   	}
>   
> -	pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
> -
>   	/* Switch back to the valid configuration.  Without first calling
>   	 * glValidateProgramPipeline, try to draw something.  Verify that
>   	 * no error is generated.



More information about the Piglit mailing list