[Piglit] [PATCH] khr_texture_compression_astc: Enable subtest reports

Nanley Chery nanleychery at gmail.com
Mon Nov 30 21:07:49 PST 2015


On Mon, Nov 30, 2015 at 07:46:37PM -0500, Ilia Mirkin wrote:
> On Mon, Nov 30, 2015 at 7:34 PM, Nanley Chery <nanleychery at gmail.com> wrote:
> > On Mon, Nov 30, 2015 at 03:50:04PM -0500, Ilia Mirkin wrote:
> >> On Wed, Oct 28, 2015 at 7:55 PM, Nanley Chery <nanleychery at gmail.com> wrote:
> >> > +
> >> > +               /* Load texture for current submode and block size */
> >> > +               load_texture("compressed", tests[subtest],
> >> > +                       block_dim_str[block_dims],
> >> > +                       &tex_compressed);
> >> > +               if (!check_error) {
> >> > +                       load_texture("decompressed", tests[subtest],
> >> > +                       block_dim_str[block_dims],
> >>
> >> Here and elsewhere, this needs to be indented to the (, or past it...
> >> otherwise it's unreadable.
> >>
> >
> > Isn't this the coding style of Piglit? See this snippet in HACKING:
> > "* Indent with 8-column tabs"
> 
> By that logic, having 0 indentation on every line would be fine. If
> you have a function call, and you have arguments on the next line,
> those arguments need to be indented deeper than that function call.
> 

Oh, I thought you were referring to the '(' in the if statement.
I'll perform the indentation you suggested for the function calls.

-Nanley


More information about the Piglit mailing list