[Piglit] [PATCH] arb_shader_storage_buffer_object: global scope binding qualifier test

[Samuel Iglesias Gonsálvez]

On 05/10/15 12:03, Tapani Pälli wrote:
> 
> 
> On 10/05/2015 12:49 PM, Tapani Pälli wrote:
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> ---
>>   .../compiler/global-scope-binding-qualifier.frag     | 20
>> ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>   create mode 100644
>> tests/spec/arb_shader_storage_buffer_object/compiler/global-scope-binding-qualifier.frag
>>
>>
>> diff --git
>> a/tests/spec/arb_shader_storage_buffer_object/compiler/global-scope-binding-qualifier.frag
>> b/tests/spec/arb_shader_storage_buffer_object/compiler/global-scope-binding-qualifier.frag
>>
>> new file mode 100644
>> index 0000000..249663a
>> --- /dev/null
>> +++
>> b/tests/spec/arb_shader_storage_buffer_object/compiler/global-scope-binding-qualifier.frag
>>
>> @@ -0,0 +1,20 @@
>> +// [config]
>> +// expect_result: fail
>> +// glsl_version: 1.50
>> +// require_extensions: GL_ARB_shader_storage_buffer_object
>> +// [end config]
>> +
>> +/* From the GL_ARB_shader_storage_buffer_object spec:
> 
> That is a lie, extension spec does not say it but it is GLSL (and GLSL
> ES) spec, I will correct it when committing if everything else is fine.
> 

GL_ARB_shader_storage_buffer_object spec modified that paragraph to add
shader storage block case.

However, it is GLSL (GLSL ES) spec who add that sentence in the first place.

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

>> + *
>> + *  "It is an error to specify the binding identifier for the global
>> + *  scope or for block member declarations."
>> + */
>> +
>> +#version 150
>> +#extension GL_ARB_shader_storage_buffer_object: require
>> +
>> +layout(binding=1) buffer;
>> +
>> +void main()
>> +{
>> +}
>>
>