[Piglit] [PATCH] arb_program_interface_query: rever linker test for querying varyings

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Wed Oct 7 01:19:38 PDT 2015


Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>


On 07.10.2015 09:34, Tapani Pälli wrote:
> This reverts commit e68f387df54767c177fcbf9e2f0b44a98525eb2a.
>
> This test is wrong. Varyings as GL_PROGRAM_INPUT should be in the
> resource list only when using SSO, not in case of full shader programs
> with multiple stages. I will write a separate test for that case.
> ---
>   .../linker/query-varyings.shader_test              | 33 ----------------------
>   1 file changed, 33 deletions(-)
>   delete mode 100644 tests/spec/arb_program_interface_query/linker/query-varyings.shader_test
>
> diff --git a/tests/spec/arb_program_interface_query/linker/query-varyings.shader_test b/tests/spec/arb_program_interface_query/linker/query-varyings.shader_test
> deleted file mode 100644
> index 994ef54..0000000
> --- a/tests/spec/arb_program_interface_query/linker/query-varyings.shader_test
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -# Tests that we can succesfully query properties of varyings
> -# that have interface GL_PROGRAM_INPUT in fragment stage.
> -#
> -# This tests that possible optimization for packing variables
> -# does not lose information about individual variables.
> -#
> -[require]
> -GLSL >= 1.10
> -GL_ARB_program_interface_query
> -
> -[vertex shader]
> -#version 110
> -varying float r, g, b;
> -void main()
> -{
> -	r = 1.0;
> -	g = 0.0;
> -	b = 1.0;
> -	gl_Position = vec4(0.0);
> -}
> -
> -[fragment shader]
> -#version 110
> -varying float r, g, b;
> -void main()
> -{
> -	gl_FragColor = vec4(r, g, b, 1.0);
> -}
> -
> -[test]
> -verify program_interface_query GL_PROGRAM_INPUT r GL_ARRAY_SIZE 1
> -verify program_interface_query GL_PROGRAM_INPUT g GL_TYPE GL_FLOAT
> -verify program_interface_query GL_PROGRAM_INPUT b GL_REFERENCED_BY_FRAGMENT_SHADER 1
>



More information about the Piglit mailing list