[Piglit] [PATCH 4/4] framework/tests/dmesg_tests.py: remove unnecessary test

baker.dylan.c at gmail.com baker.dylan.c at gmail.com
Mon Oct 12 15:13:53 PDT 2015


From: Dylan Baker <baker.dylan.c at gmail.com>

TestResult already puts restrictions on what values it can store, so we
don't need to ensure that it can still be serialized, it will fail in
some other test non-specifically long before this test is able to
identify problems.

Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
---
 framework/tests/dmesg_tests.py | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/framework/tests/dmesg_tests.py b/framework/tests/dmesg_tests.py
index 7833808..5c7b7ab 100644
--- a/framework/tests/dmesg_tests.py
+++ b/framework/tests/dmesg_tests.py
@@ -30,10 +30,6 @@ import os
 import subprocess
 import re
 
-try:
-    import simplejson as json
-except ImportError:
-    import json
 import nose.tools as nt
 from nose.plugins.skip import SkipTest
 from nose.plugins.attrib import attr
@@ -41,7 +37,6 @@ from nose.plugins.attrib import attr
 from framework import dmesg, status
 import framework.core
 import framework.test
-import framework.backends
 import framework.tests.utils as utils
 
 
@@ -342,20 +337,6 @@ def test_update_result_add_dmesg():
            msg="result does not have dmesg member but should")
 
 
-def test_json_serialize_updated_result():
-    """dmesg.Dmesg.update_result: The TestResult is still json serializable"""
-    test = TestDmesg()
-
-    result = framework.results.TestResult()
-    result.result = 'pass'
-
-    test._new_messages = ['some', 'new', 'messages']
-    result = test.update_result(result)
-
-    encoder = json.JSONEncoder(default=framework.backends.json.piglit_encoder)
-    encoder.encode(result)
-
-
 @attr('privileged')
 def test_execute_dmesg():
     """test.base.Test.execute: dmesg statuses are applied
-- 
2.6.1



More information about the Piglit mailing list