[Piglit] [PATCH] glsl-es-3.10: compiler test for glHelperInvocation

[Tapani Pälli]

On 10/13/2015 09:09 PM, Ilia Mirkin wrote:
> On Tue, Oct 13, 2015 at 2:15 AM, Tapani Pälli <tapani.palli at intel.com> wrote:
>> Test passes on Nvidia binary driver (346.59).
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> ---
>>   tests/spec/glsl-es-3.10/compiler/helper-invocation.frag | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>   create mode 100644 tests/spec/glsl-es-3.10/compiler/helper-invocation.frag
>>
>> diff --git a/tests/spec/glsl-es-3.10/compiler/helper-invocation.frag b/tests/spec/glsl-es-3.10/compiler/helper-invocation.frag
>> new file mode 100644
>> index 0000000..401d7da
>> --- /dev/null
>> +++ b/tests/spec/glsl-es-3.10/compiler/helper-invocation.frag
>> @@ -0,0 +1,15 @@
>> +// [config]
>> +// expect_result: pass
>> +// glsl_version: 3.10 es
>> +// check_link: true
>> +// [end config]
>> +//
>> +
>> +#version 310 es
>> +out highp vec4 color;
>> +void main()
>> +{
>> +        if (gl_HelperInvocation)
>> +                discard;
>> +        color = vec4(0.0);
>> +}
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>
> [presumably you saw my patches for adding this in mesa... perhaps you
> even commented?]

Yep, I made this test to gain some more visibility to the fact that we 
are missing this :) I'm not sure if I have enough gallium knowledge to 
review all of those patches but I can take another look today.

// Tapani