[Piglit] [PATCH v2] arb_texture_view: Add test for 2d layer as 2d

Emil Velikov emil.l.velikov at gmail.com
Thu Oct 15 17:55:36 PDT 2015


On 16 October 2015 at 01:14, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Thu, Oct 15, 2015 at 8:07 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> Hi Glenn,
>>
>> On 16 October 2015 at 00:10, Glenn Kennard <glenn.kennard at gmail.com> wrote:
[snip]
>>> +                       subtest_pass &= test_single_layer(&testparams[n], layer);
>> subtest_pass = test_foo() && subtest_pass;
>>
>>> +               }
>>> +               piglit_report_subtest_result(subtest_pass ? PIGLIT_PASS : PIGLIT_FAIL,
>>> +                       testparams[n].desc);
>>> +               pass &= subtest_pass;
>> pass = subtest_pass && pass;
>>
>> Without these we might bail on the remaining tests, if one fails.
>
> Nope. && short-circuits, & doesn't.
Indeed it doesn't. Not sure what I was smoking earlier.

-Emil


More information about the Piglit mailing list