[Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests

[Mark Janes]

Emil Velikov <emil.l.velikov at gmail.com> writes:

> On 25 September 2015 at 16:40, Mark Janes <mark.a.janes at intel.com> wrote:
>> With the push of SSBO support in mesa, one of these tests continues to
>> fail, but only on broadwell:
>>
>> piglit.spec.arb_shader_storage_buffer_object.array-ssbo-binding
>>
>>     Standard Output
>>
>>     /tmp/build_root/m64/lib/piglit/bin/arb_shader_storage_buffer_object-array-ssbo-binding -auto -fbo
>>     piglit: debug: Requested an OpenGL 3.2 Core Context, and received a matching 3.3 context
>>
>>     Wrong 0 value in buffer[1]: 0.00
>>
> The test seems to be comparing a float with an integer there. Perhaps
> one should use {+,-}0.0f or lambda ?
>
>         float *map;
>         ...
>                 if (map[i] != 0) {
>                        printf("Wrong %d value in buffer[0]: %.2f\n",
>                               i, map[i]);

The output of the test is confusing: a value of 0 or >10 is a failure.
The float comparison is not the issue.

>
> -Emil