[Piglit] [PATCH] Fix oglconform integration.
Dylan Baker
baker.dylan.c at gmail.com
Tue Oct 20 15:20:17 PDT 2015
On Mon, Oct 19, 2015 at 11:35:27PM -0700, Kenneth Graunke wrote:
> Everything reported 'fail' all the time because interpretResult()
> wasn't updated amdist all the Piglit framework rewriting.
> ---
> tests/oglconform.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> This seems to get it working again, but honestly at this point I hardly
> even recognize the codebase...
>
> diff --git a/tests/oglconform.py b/tests/oglconform.py
> index 4ec127e..cdae4d4 100644
> --- a/tests/oglconform.py
> +++ b/tests/oglconform.py
> @@ -55,12 +55,12 @@ class OGLCTest(Test):
> '-test', category, subtest])
>
> def interpret_result(self):
> - if self.skip_re.search(self.result['out']) is not None:
> - self.result['result'] = 'skip'
> - elif re.search('Total Passed : 1', self.result['out']) is not None:
> - self.result['result'] = 'pass'
> + if self.skip_re.search(self.result.out) is not None:
> + self.result.result = 'skip'
> + elif re.search('Total Passed : 1', self.result.out) is not None:
> + self.result.result = 'pass'
> else:
> - self.result['result'] = 'fail'
> + self.result.result = 'fail'
>
> # Create a new top-level 'oglconform' category
>
> --
> 2.6.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
This looks correct, although I don't have a copy of oglconform to test
with.
Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20151020/09c1360c/attachment.sig>
More information about the Piglit
mailing list