[Piglit] [PATCH] Replace vs-tcs-tes-tessinner-tessouter-inputs with two new tests.
maraeo at gmail.com
Wed Oct 21 03:45:07 PDT 2015
On Wed, Oct 21, 2015 at 9:26 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Wed, Oct 21, 2015 at 3:22 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> vs-tcs-tes-tessinner-tessouter-inputs tried to verify that all vector
>> components written by the TCS were present in the TES. However, this
>> is not guaranteed. According to the ARB_tessellation_shader spec:
>> "Tessellation Evaluation Shader Inputs
>> For triangular tessellation, gl_TessLevelOuter and gl_TessLevelInner
>> will be undefined. For isoline tessellation, gl_TessLevelOuter,
>> gl_TessLevelOuter, and both values in gl_TessLevelInner are undefined."
>> This patch removes the broken test, and replaces it with two new ones.
>> One uses quads, and probes all 4/2 components. The other uses
>> triangles, but only probes the 3/1 components that are actually defined.
>> Testing both types of domains is especially useful for i965, which
>> stores the data in different layouts depending on the domain.
> I think r600 might have a similar situation as well.
No, r600 is the same as radeonsi in this regard.
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
More information about the Piglit