[Piglit] [PATCH v2 2/2] framework/summary/common.py: Add enabled, disabled, and skip to changes
baker.dylan.c at gmail.com
baker.dylan.c at gmail.com
Wed Oct 21 11:23:08 PDT 2015
From: Dylan Baker <baker.dylan.c at gmail.com>
This changes the changes category to include every case were the first
status is not the same as the previous status, including
<status> <-> notrun, except when <status> is skip.
This fixes the failing unit tests from the previous commit.
v2: - don't include skip <-> notrun (Ilia)
cc: Michel Dänzer <michel at daenzer.net>
Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
---
framework/summary/common.py | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/framework/summary/common.py b/framework/summary/common.py
index 95af02a..671a540 100644
--- a/framework/summary/common.py
+++ b/framework/summary/common.py
@@ -101,7 +101,26 @@ class Names(object):
@lazy_property
def changes(self):
- return self.__diff(operator.ne)
+ def handler(names, name, prev, cur):
+ """Handle missing tests.
+
+ For changes we want literally anything where the first result
+ isn't the same as the second result.
+
+ """
+ def _get(res):
+ try:
+ return res.get_result(name)
+ except KeyError:
+ return so.NOTRUN
+
+ # Add any case of a != b except skip <-> notrun
+ cur = _get(cur)
+ prev = _get(prev)
+ if cur != prev and {cur, prev} != {so.SKIP, so.NOTRUN}:
+ names.add(name)
+
+ return self.__diff(operator.ne, handler=handler)
@lazy_property
def problems(self):
--
2.6.1
More information about the Piglit
mailing list