[Piglit] [PATCH] arb_draw_indirect: Adopt to INVALID_VALUE on unaligned DrawIndirect

Marta Lofstedt marta.lofstedt at linux.intel.com
Thu Oct 29 06:49:07 PDT 2015


From: Marta Lofstedt <marta.lofstedt at intel.com>

In Mesa commit:
2c91e086563541271668f9ea6ca58689c0c97d44

It was concluded that Mesa should follow the definition from
OpenGL 4.4 specification, section 10.4 and OpenGL ES 3.1
section 10.5:

    "An INVALID_VALUE error is generated if indirect is not
     a multiple of the size, in basic machine units, of uint."

Previous definitions called for an INVALID_OPERATION to be
generated.

Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
---
 tests/spec/arb_draw_indirect/api-errors.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/spec/arb_draw_indirect/api-errors.c b/tests/spec/arb_draw_indirect/api-errors.c
index dfa93e4..7f25ea9 100644
--- a/tests/spec/arb_draw_indirect/api-errors.c
+++ b/tests/spec/arb_draw_indirect/api-errors.c
@@ -161,7 +161,7 @@ check_draw_beyond_end(void)
 static bool
 check_draw_misaligned(void)
 {
-	/* An INVALID_OPERATION error is generated
+	/* An INVALID_VALUE error is generated
 	 * .. or if <indirect> is not word aligned.
 	 */
 
@@ -172,7 +172,7 @@ check_draw_misaligned(void)
 
 	glDrawArraysIndirect(GL_TRIANGLES, (GLvoid const *)1);	/* misaligned */
 	
-	if (!piglit_check_gl_error(GL_INVALID_OPERATION))
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
 		return false;
 
 	return true;
-- 
2.1.4



More information about the Piglit mailing list