[Piglit] [PATCH] arb_copy_image: add new format swizzle test

Fredrik Höglund fredrik at kde.org
Tue Sep 1 09:22:47 PDT 2015


On Tuesday 01 September 2015, Brian Paul wrote:
> On 08/31/2015 05:38 PM, Ilia Mirkin wrote:
> > On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> >> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
> >>
> >> Thanks a lot for doing this! I assume that it fails with your gallium
> >> ARB_copy_image implementation as I predicted?
> 
> Yes.  In Mesa, I added some code that checks for swizzles and uses 
> pipe_context::blit() instead.  Seems to fix things, but I need to spend 
> more time on it.

This test is not sufficient though, because it's when you have a copy
from B8G8R8A8 to R16G16, or a similar situation, that things get really
interesting.

Fredrik



More information about the Piglit mailing list