[Piglit] [RFC] general: add draw-sync to all.py
Albert Freeman
albertwdfreeman at gmail.com
Fri Sep 4 21:14:43 PDT 2015
But should the test be moved to a group different from "!opengl 1.5"?
On 4 September 2015 at 19:15, Eric Anholt <eric at anholt.net> wrote:
> Brian Paul <brianp at vmware.com> writes:
>
>> On 09/02/2015 11:45 AM, Albert Freeman wrote:
>>> The draw-sync test (from 2011) in the tests/general directory was never placed in all.py.
>>>
>>> Signed-off-by: Albert Freeman <albertwdfreeman at gmail.com>
>>> ---
>>> quick.py finishes with draw-sync passing
>>> This is an RFC since I placed the test in "!opengl 1.5" (since similar looking tests were there).
>>>
>>> tests/all.py | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/all.py b/tests/all.py
>>> index fcfc5cd..2c61676 100644
>>> --- a/tests/all.py
>>> +++ b/tests/all.py
>>> @@ -1061,6 +1061,7 @@ with profile.group_manager(
>>> g(['draw-elements', 'user'], 'draw-elements-user', run_concurrent=False)
>>> g(['draw-vertices'], run_concurrent=False)
>>> g(['draw-vertices', 'user'], 'draw-vertices-user', run_concurrent=False)
>>> + g(['draw-sync'], run_concurrent=False)
>>> g(['isbufferobj'], run_concurrent=False)
>>> g(['depth-tex-compare'], run_concurrent=False)
>>> g(['gl-1.5-normal3b3s-invariance', 'GL_BYTE'],
>>>
>>
>> I'm not sure this has to be run non-concurrently. Eric was the original
>> author. Eric?
>
> I think it would be fine concurrent.
More information about the Piglit
mailing list