[Piglit] [PATCH v2 1/4] arb_texture_compression/invalid-formats: add ASTC to list of formats

Chad Versace chad.versace at intel.com
Tue Sep 8 10:59:21 PDT 2015


On Tue 08 Sep 2015, Dylan Baker wrote:
> This is extending an existing test, does it really need to be added?

If I interpreted correctly the output of `grep
arb_texture_compression-invalid-formats tests/all.py`, then yes.

Nanley, without adding your ASTC invalid format tests to all.py, do they
still get run during a full Piglit run?

> On Sep 8, 2015 09:50, "Chad Versace" <chad.versace at intel.com> wrote:
> 
> > On Tue 08 Sep 2015, Chad Versace wrote:
> > > On Fri 28 Aug 2015, Nanley Chery wrote:
> > > > From: Nanley Chery <nanley.g.chery at intel.com>
> > > >
> > > > ASTC formats are added to the list of formats that should not be
> > returned by the
> > > > COMPRESSED_TEXTURE_FORMATS query.
> > > >
> > > > Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> > > > ---
> > > >  .../spec/arb_texture_compression/invalid-formats.c | 51
> > +++++++++++++++++++++-
> > > >  1 file changed, 50 insertions(+), 1 deletion(-)
> > >
> > > Patch 1 is
> > > Reviewed-by: Chad Versace <chad.versace at intel.com>
> >
> > Oops. I retract the rb. You need to add the test to all.py.
> > _______________________________________________
> > Piglit mailing list
> > Piglit at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/piglit
> >


More information about the Piglit mailing list