[Piglit] [PATCH] framework/summary.py: Always print number of changes in console mode

[Dylan Baker]

On Wed, Sep 09, 2015 at 03:25:50PM -0400, Tom Stellard wrote:
> On Wed, Sep 09, 2015 at 11:05:55AM -0700, Dylan Baker wrote:
> > Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>
> > 
> > On a related note, I have a series that seriously overhauls the summary
> > code, including fixing the console/text summary, producing a column for
> > each result. It does include changes, fixes, and regressions in all
> > cases like this patch. I'm hoping to have that cleaned up and on the
> > list today.
> > 
> > On a tangent, why are you parsing the output of this, it seems like the
> > CSV summary would be easier to pass to another script than this, which
> > is volatile.
> > 
> 
> I have a buildbot seti up to run piglit and the way it detects whether
> or no there have been piglit regressions is by running piglit summary
> console and then parsing the output.
> 
> The CSV summary seems to only accept a single result file, unless I'm
> doing something wrong:
> 
> tstellar at localhost ~/piglit $ ./piglit summary csv  -o out.csv results/master--150727-/ results/master-BONAIRE-150223-/
> usage: piglit [-h] [-o <Output File>] <Input Files>
> piglit: error: unrecognized arguments: results/master-BONAIRE-150223-/
> 
> -Tom

You're right. I'll fix that, it seems useful to get more than one result
out of it.

> 
> 
> > Dylan
> > 
> > On Wed, Sep 09, 2015 at 12:28:21PM +0000, Tom Stellard wrote:
> > > The counts for changes, fixes, and regressions are now reported as zero
> > > when no changes are detect rather than being omitted from the output.
> > > 
> > > This makes it easier for scripts to parse the output of piglit summary
> > > console, becuase now when there are no regressions piglit always
> > > outputs:
> > > 
> > > regressions: 0
> > > 
> > > Before when there where no regressions, piglit would either print no
> > > regression line or it would print 'regressions: 0'
> > > ---
> > >  framework/summary.py | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/framework/summary.py b/framework/summary.py
> > > index 80cb181..e56c0f2 100644
> > > --- a/framework/summary.py
> > > +++ b/framework/summary.py
> > > @@ -604,7 +604,10 @@ class Summary:
> > >                        "      fixes: {fixes}\n"
> > >                        "regressions: {regressions}".format(
> > >                            **{k: len(v) for k, v in self.tests.iteritems()}))
> > > -
> > > +            else:
> > > +                print("    changes: 0\n"
> > > +                      "      fixes: 0\n"
> > > +                      "regressions: 0")
> > >              print("      total: {}".format(sum(self.totals.itervalues())))
> > >  
> > >          # Print the name of the test and the status from each test run
> > > -- 
> > > 2.0.4
> > > 
> > > _______________________________________________
> > > Piglit mailing list
> > > Piglit at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/piglit
> 
> 
> 
> > _______________________________________________
> > Piglit mailing list
> > Piglit at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/piglit
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150909/a60ebd77/attachment.sig>