[Piglit] [PATCH 8/9] tests/all.py: add arb_robustness_draw-vbo-bounds

Ian Romanick idr at freedesktop.org
Wed Sep 9 14:38:46 PDT 2015


On 09/02/2015 01:27 PM, Jose Fonseca wrote:
> On 02/09/15 20:51, Dylan Baker wrote:
>> This was never added to all.py
> 
> Yes, that was because the test uses random numbers, hence might yield
> variable results (fail once, pass another).
> 
> Rather than all.py, it probably makes sense to move this sort of tests
> to a new stress.py test-list.
> 
> The other alternative is use reproduceable pseudo-random numbers, or a
> pre-generated set of data from a plaintext file.

There is such a random number generator in piglit, but it looks like
it's only available for C++ tests (tests/util/mersenne.hpp).  It should
be easy enough to make it available to C tests.

> Jose
> 
>> cc: José Fonseca <jfonseca at vmware.com>
>> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
>> ---
>>
>> Does this actually need run_concurrent=False?
>>
>>   tests/all.py | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/all.py b/tests/all.py
>> index 9c55dd7..ca72b65 100644
>> --- a/tests/all.py
>> +++ b/tests/all.py
>> @@ -2249,6 +2249,7 @@ with profile.group_manager(
>>           PiglitGLTest,
>>           grouptools.join('spec', 'ARB_robustness')) as g:
>>       g(['arb_robustness_client-mem-bounds'], run_concurrent=False)
>> +    g(['arb_robustness_draw-vbo-bounds'], run_concurrent=False)
>>
>>   # Group ARB_shader_texture_lod
>>   with profile.group_manager(
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit



More information about the Piglit mailing list