[Piglit] [PATCH] Add a biased variants of a textureLod() miplevel tests

Krzesimir Nowak krzesimir at kinvolk.io
Thu Sep 10 03:58:51 PDT 2015


On Wed, Sep 9, 2015 at 10:07 PM, Brian Paul <brianp at vmware.com> wrote:

> On 09/09/2015 03:59 AM, Krzesimir Nowak wrote:
>
>> These tests have the same purpose as the
>> {vs,fs}-textureLod-miplevels.shader_test ones. These are actually a
>> slightly modified copies of those. The modifications are setting the
>> lod_bias parameter to 1.0 and updating the expected colors in probes.
>>
>> This exposes a bug in softpipe, where it does not take lod_bias into
>> account, so the colors returned in these tests are the same as in
>> unbiased versions.
>> ---
>>   .../fs-textureLod-miplevels-biased.shader_test     | 196
>> +++++++++++++++++++++
>>   .../vs-textureLod-miplevels-biased.shader_test     | 196
>> +++++++++++++++++++++
>>   2 files changed, 392 insertions(+)
>>   create mode 100644
>> tests/spec/glsl-1.30/execution/fs-textureLod-miplevels-biased.shader_test
>>   create mode 100644
>> tests/spec/glsl-1.30/execution/vs-textureLod-miplevels-biased.shader_test
>>
>
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
>
> I verified that the tests pass on NVIDIA too.
>
>
I verified that the tests pass on i965.


> I'll commit this patch for you (AFAIK, you don't have git write ability).
>
>
Yes, indeed I don't have write access, thanks.


> -Brian
>
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150910/b3379074/attachment-0001.html>


More information about the Piglit mailing list