[Piglit] [PATCH 2/2] HACKING: Notes need to be added before the "---" line.

[Ilia Mirkin]

On Wed, Apr 6, 2016 at 4:03 PM, Erik Brangs <erik.brangs at gmx.de> wrote:
> ---
>  HACKING | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/HACKING b/HACKING
> index 4156543..6942120 100644
> --- a/HACKING
> +++ b/HACKING
> @@ -188,7 +188,7 @@ are also welcome to add a "Signed-off-by" line to your patch, but it
>  is not required.
>
>  For developers who are new to piglit: when submitting a patch, it is
> -helpful to add a note (after the "---" line in the patch file)
> +helpful to add a note (before the first "---" line in the patch file)

If you add it before, it ends up in the commit log. After, it's just
in the email. Most notes aren't particularly relevant in the commit
logs... I put them afterwards. Do you really want every commit, in the
repo, to say "NOTE: I don't have commit access"?

>  indicating that you are new to the project and don't have commit
>  access; that way once your patch has been revised to meet our
>  standards of correctness and coding style, we will know that we should
> --
> 2.5.0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit