[Piglit] [PATCH 2/2] tests/all.py: simplify some strings using formatters for no reason

Vinson Lee vlee at freedesktop.org
Thu Apr 7 06:11:08 UTC 2016


On Wed, Apr 6, 2016 at 9:14 AM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> I noticed these while writing the previous patch. They aren't hurting
> anything, but it really isn't necessary to have them.
>
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  tests/all.py | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tests/all.py b/tests/all.py
> index 6261720..d4efb19 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -641,17 +641,16 @@ with profile.group_manager(PiglitGLTest, 'shaders') as g:
>      g(['glsl-getactiveuniform-count',
>         os.path.join(TESTS_DIR, 'shaders', 'glsl-getactiveuniform-length.vert'),
>         '1'],
> -      'glsl-getactiveuniform-count: {}'.format('glsl-getactiveuniform-length'))
> +      'glsl-getactiveuniform-count: glsl-getactiveuniform-length')
>      g(['glsl-getactiveuniform-count',
>         os.path.join(TESTS_DIR, 'shaders',
>                      'glsl-getactiveuniform-ftransform.vert'),
>         '2'],
> -      'glsl-getactiveuniform-count: {}'.format(
> -          'glsl-getactiveuniform-ftransform'))
> +      'glsl-getactiveuniform-count: glsl-getactiveuniform-ftransform')
>      g(['glsl-getactiveuniform-count',
>         os.path.join(TESTS_DIR, 'shaders', 'glsl-getactiveuniform-mvp.vert'),
>         '2'],
> -      'glsl-getactiveuniform-count: {}'.format('glsl-getactiveuniform-mvp'))
> +      'glsl-getactiveuniform-count: glsl-getactiveuniform-mvp')
>
>      for subtest in ('interstage', 'intrastage', 'vs-gs'):
>          g(['version-mixing', subtest])
> --
> 2.8.0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit

Reviewed-by: Vinson Lee <vlee at freedesktop.org>


More information about the Piglit mailing list