[Piglit] [PATCH 5/8] framework: cleanup a bunch of style problems in piglit-print-commands

Andres Gomez agomez at igalia.com
Thu Apr 7 07:48:29 UTC 2016


Reviewed-by: Andres Gomez <agomez at igalia.com>

On Wed, 2016-03-30 at 11:18 -0700, Dylan Baker wrote:
> Add docstrings, and stuff like that.
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  piglit-print-commands.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/piglit-print-commands.py b/piglit-print-commands.py
> index 17779e3..d23fc50 100755
> --- a/piglit-print-commands.py
> +++ b/piglit-print-commands.py
> @@ -21,6 +21,7 @@
>  # OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>  # DEALINGS IN THE SOFTWARE.
>  
> +"""Print each test's command in a consumable format."""
>  
>  from __future__ import (
>      absolute_import, division, print_function, unicode_literals
> @@ -51,6 +52,7 @@ def get_command(test, piglit_dir):
>  
>  
>  def main():
> +    """The main function."""
>      input_ = [i.decode('utf-8') for i in sys.argv[1:]]
>      parser = argparse.ArgumentParser(parents=[parsers.CONFIG])
>      parser.add_argument("-t", "--include-tests",
> @@ -81,7 +83,7 @@ def main():
>  
>      profile_._prepare_test_list()
>      for name, test in profile_.test_list.items():
> -        assert(isinstance(test, Test))
> +        assert isinstance(test, Test)
>          print(name, ':::', get_command(test, piglit_dir))
>  
>  
-- 
Br,

Andres




More information about the Piglit mailing list