[Piglit] [PATCH v3 4/4] generators: Add a simple generator for enabled and disabled defines

Dylan Baker baker.dylan.c at gmail.com
Wed Apr 13 00:38:54 UTC 2016


Quoting Ilia Mirkin (2016-04-12 17:32:37)
> On Tue, Apr 12, 2016 at 8:20 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> > +            if not version.is_es:
> > +                # if the actual version is GL and is less than 140 make a
> > +                # compat test and a core test and a compat test
> 
> Probably just the one compat test ;)
> 
> Otherwise this is Acked-by: Ilia Mirkin <imirkin at alum.mit.edu>
> 
> Thanks a lot for automating these -- I was always lazy (/forgetful)
> about adding them for new exts.
> 
>   -ilia

Yeah, Matt and I noticed that coverage for this was very hit or miss,
and bascially none of what we had covered tess or compute, and very
little cover geometry.

I'll fix that comment

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160412/f1a9fc83/attachment.sig>


More information about the Piglit mailing list