[Piglit] [PATCH 2/2] arb_gpu_shader5: Remove out of spec ldexp() test case.

Jason Ekstrand jason at jlekstrand.net
Wed Apr 13 19:32:45 UTC 2016


both are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Wed, Apr 13, 2016 at 12:07 PM, Matt Turner <mattst88 at gmail.com> wrote:

> Unfortunately, the GLSL spec says that exponent values outside of [-126,
> 128] are undefined or may be flushed to zero.
> ---
>  .../execution/built-in-functions/fs-ldexp.shader_test          | 10
> ----------
>  1 file changed, 10 deletions(-)
>
> diff --git
> a/tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-ldexp.shader_test
> b/tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-ldexp.shader_test
> index 785eee5..989c1da 100644
> ---
> a/tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-ldexp.shader_test
> +++
> b/tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-ldexp.shader_test
> @@ -82,14 +82,4 @@ uniform ivec4 given_exponent -127 -127 -127 -127
>  draw arrays GL_TRIANGLE_FAN 0 4
>  probe all rgba 0.0 1.0 0.0 1.0
>
> -uniform vec4 expected_float 0.0 -0.0 0.0 -0.0
> -uniform vec4 given_float 1.1754944e-38 -1.1754944e-38 3.40282347e38
> -3.40282347e38
> -# For the FLT_MAX case -255 comes from (-127 + -127 + -1).
> -#   ldexp(FLT_MAX, -127)           = 0x1.fffffep+0 (1.999999881)
> -#   ldexp(FLT_MAX, -127 - 127)     = 0x1p-126 (epsilon above FLT_MIN)
> -#   ldexp(FLT_MAX, -127 - 127 - 1) = 0.0
> -uniform ivec4 given_exponent -1 -1 -255 -255
> -draw arrays GL_TRIANGLE_FAN 0 4
> -probe all rgba 0.0 1.0 0.0 1.0
> -
>  # Overflow is undefined according to the GLSL spec, so nothing to test.
> --
> 2.7.3
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160413/795b2fcf/attachment.html>


More information about the Piglit mailing list