[Piglit] [PATCH] arb_get_program_binary/retrievable_hint: fix typo

[Dylan Baker]

Quoting Haixia Shi (2016-04-14 11:11:25)
> The variable "pass" is incorrectly set to false unconditionally. This
> prevents the test from ever passing.
> 
> Signed-off-by: Haixia Shi <hshi at chromium.org>
> ---
>  tests/spec/arb_get_program_binary/retrievable_hint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/spec/arb_get_program_binary/retrievable_hint.c b/tests/spec/arb_get_program_binary/retrievable_hint.c
> index 8283c5b..4b9264c 100644
> --- a/tests/spec/arb_get_program_binary/retrievable_hint.c
> +++ b/tests/spec/arb_get_program_binary/retrievable_hint.c
> @@ -97,7 +97,7 @@ piglit_init(int argc, char **argv)
>                         pass = false;
>                 }
>         } else
> -               pass = false;
> +               pass = true;
>  
>         /* The ARB_get_program_binary spec says:
>          *
> -- 
> 2.8.0.rc3.226.g39d4020
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit

Hi,

I don't think this patch is correct. The context doesn't show it, but
this else case is the else of '!got_error', which means pass is set to
false when there is an error.

I've CC'd Ian (who wrote the test). Maybe he knows better.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160414/eb249a86/attachment.sig>