[Piglit] [PATCH v2] arb_get_program_binary/retrievable_hint: fix typo

[Ian Romanick]

On 04/14/2016 01:34 PM, Haixia Shi wrote:
> The function GLboolean piglit_check_gl_error() returns GL_TRUE when there is
> no error, and GL_FALSE when there is an error.
> 
> Signed-off-by: Haixia Shi <hshi at chromium.org>
> Cc: Dylan Baker <baker.dylan.c at gmail.com>
> Cc: Ian Romanick <idr at freedesktop.org>
> ---
>  tests/spec/arb_get_program_binary/retrievable_hint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/spec/arb_get_program_binary/retrievable_hint.c b/tests/spec/arb_get_program_binary/retrievable_hint.c
> index 8283c5b..9263a89 100644
> --- a/tests/spec/arb_get_program_binary/retrievable_hint.c
> +++ b/tests/spec/arb_get_program_binary/retrievable_hint.c
> @@ -79,7 +79,7 @@ piglit_init(int argc, char **argv)
>  	 */
>  	value = 0xDEADBEEF;
>  	glGetProgramiv(prog, GL_PROGRAM_BINARY_RETRIEVABLE_HINT, &value);
> -	got_error = piglit_check_gl_error(0);
> +	got_error = !piglit_check_gl_error(0);
>  
>  	if (!got_error) {

I think this would be better as:

        if (piglit_check_gl_error(GL_NO_ERROR)) {

end delete the got_error variable altogether.

I'm really not sure why I didn't do it that way to begin with.

>  		if (value == 0xDEADBEEF) {
>