[Piglit] [PATCH 0/8] Additional tests for ARB_gpu_shader_fp64 extension

Andres Gomez agomez at igalia.com
Mon Apr 18 13:03:02 UTC 2016 

Hi,

we are still in need of reviews for this series.

If we don't manage to get explicit reviews by the end of this week we
will assume that all is OK and will proceed to land them.

Br.

On Tue, 2016-04-05 at 11:09 +0300, Andres Gomez wrote:
> Hi,
> 
> this series is, for the most of it, still unreviewed.
> 
> We'd welcome some help to get this into piglit with guarantees that
> the
> tests added are OK :)
> 
> Br.
> 
> On Tue, 2016-03-15 at 17:50 +0200, Andres Gomez wrote:
> > 
> > This series provides additional tests for the ARB_gpu_shader_fp64
> > extension:
> > 
> > https://www.opengl.org/registry/specs/ARB/gpu_shader_fp64.txt
> > 
> > This work is complemented with the corresponding bug to add support
> > for this extension into the i965 shader backend at:
> > 
> > https://bugs.freedesktop.org/show_bug.cgi?id=92760
> > 
> > There will still come more patches once we have clarified the
> > expected
> > behavior with certain conversions and certain uses of the "flat"
> > interpolation qualifier:
> > 
> > https://lists.freedesktop.org/archives/mesa-dev/2016-March/109117.h
> > tm
> > l
> > https://lists.freedesktop.org/archives/mesa-dev/2016-March/110038.h
> > tm
> > l
> > 
> > Cheers,
> > Andres (on behalf of the team that worked on this).
> > 
> > --
> > 
> > Andres Gomez (2):
> >   arb_gpu_shader_fp64: Adds GS preprocessor define test
> >   arb_gpu_shader_fp64: Adds uniform buffers VS tests
> > 
> > Juan A. Suarez Romero (6):
> >   arb_gpu_shader_fp64: test glGetUniformdv interface
> >   arb_gpu_shader_fp64: gl_FragColor is deprecated in glsl >= 1.30
> >   arb_gpu_shader_fp64: add tests for SSBO
> >   arb_gpu_shader_fp64: use generator to test in/out attributes
> >   arb_gpu_shader_fp64: add tests for UBOs
> >   arb_gpu_shader_fp64: add more tests for this spec
> > 
> >  generated_tests/CMakeLists.txt                     |   8 +
> >  generated_tests/gen_inout_fp64.py                  | 219
> > +++++++++++++
> >  .../templates/gen_inout_fp64/template.frag.mako    |  15 +
> >  .../templates/gen_inout_fp64/template.vert.mako    |  15 +
> >  .../gen_inout_fp64/vs-out-fs-in_template.mako      |  25 +-
> >  tests/all.py                                       |  13 +-
> >  tests/spec/arb_gpu_shader_fp64/CMakeLists.txt      |   1 +
> >  .../execution/CMakeLists.gl.txt                    |   5 +-
> >  .../execution/double-suffix-value.shader_test      |  33 ++
> >  .../execution/fs-getuniformdv.c                    | 339
> > ++++++++++++++++++++
> >  .../fs-indirect-temp-double-const-src.shader_test  |   9 +-
> >  .../fs-indirect-temp-double-dst.shader_test        |  10 +-
> >  .../fs-indirect-temp-double-src.shader_test        |  10 +-
> >  .../execution/fs-isinf-dvec.shader_test            |  66 ++++
> >  .../execution/fs-isnan-dvec.shader_test            |  73 +++++
> >  .../arb_gpu_shader_fp64/execution/getuniformdv.c   | 302 ---------
> > ---------
> >  .../execution/gs-fs-vs-double.shader_test          |  12 +-
> >  .../execution/gs-getuniformdv.c                    | 355
> > +++++++++++++++++++++
> >  .../execution/gs-isinf-dvec.shader_test            |  96 ++++++
> >  .../execution/gs-isnan-dvec.shader_test            | 104 ++++++
> >  .../execution/uniform-invalid-operation.c          | 128 ++++++++
> >  .../execution/vs-constructors.shader_test          | 124 +++++++
> >  .../execution/vs-decrement-dvec.shader_test        |  67 ++++
> >  .../execution/vs-getuniformdv.c                    | 339
> > ++++++++++++++++++++
> >  .../execution/vs-increment-dvec.shader_test        |  67 ++++
> >  .../execution/vs-isinf-dvec.shader_test            |  78 +++++
> >  .../execution/vs-isnan-dvec.shader_test            |  85 +++++
> >  .../execution/vs-out-fs-in-double.shader_test      |  43 ---
> >  .../arb_gpu_shader_fp64/preprocessor/define.geom   |  19 ++
> >  .../preprocessor/fs-output-double.frag             |  23 --
> >  .../preprocessor/vs-input-double.vert              |  24 --
> >  .../shader_storage/CMakeLists.gl.txt               |  15 +
> >  .../shader_storage/CMakeLists.txt                  |   1 +
> >  .../layout-std140-fp64-mixed-shader.c              | 285
> > +++++++++++++++++
> >  .../shader_storage/layout-std140-fp64-shader.c     | 232
> > ++++++++++++++
> >  .../layout-std430-fp64-mixed-shader.c              | 318
> > ++++++++++++++++++
> >  .../shader_storage/layout-std430-fp64-shader.c     | 266
> > +++++++++++++++
> >  .../uniform_buffers/fs-array-copy.shader_test      |  40 +++
> >  .../uniform_buffers/fs-dmat4-row-major.shader_test |  33 ++
> >  .../uniform_buffers/fs-dmat4.shader_test           |  34 ++
> >  .../fs-double-array-const-index.shader_test        |  37 +++
> >  .../fs-double-array-variable-index.shader_test     |  45 +++
> >  .../fs-double-bool-double.shader_test              |  38 +++
> >  ...ouble-uniform-array-direct-indirect.shader_test |  34 ++
> >  .../fs-doubles-float-mixed.shader_test             |  40 +++
> >  .../uniform_buffers/fs-doubles.shader_test         |  40 +++
> >  ...dvec4-uniform-array-direct-indirect.shader_test |  32 ++
> >  .../uniform_buffers/fs-nested-struct.shader_test   |  56 ++++
> >  .../uniform_buffers/fs-ubo-direct-1.shader_test    |  38 +++
> >  .../fs-ubo-load.indirect.1.shader_test             |  38 +++
> >  .../fs-ubo-load.indirect.2.shader_test             |  34 ++
> >  .../fs-ubo-load.indirect.3.shader_test             |  37 +++
> >  .../fs-ubo-load.indirect.4.shader_test             |  52 +++
> >  .../uniform_buffers/gs-array-copy.shader_test      |  69 ++++
> >  .../uniform_buffers/gs-dmat4-row-major.shader_test |  60 ++++
> >  .../uniform_buffers/gs-dmat4.shader_test           |  60 ++++
> >  .../gs-double-array-const-index.shader_test        |  63 ++++
> >  .../gs-double-array-variable-index.shader_test     |  71 +++++
> >  .../gs-double-bool-double.shader_test              |  65 ++++
> >  ...ouble-uniform-array-direct-indirect.shader_test |  64 ++++
> >  .../gs-doubles-float-mixed.shader_test             |  66 ++++
> >  ...dvec4-uniform-array-direct-indirect.shader_test |  62 ++++
> >  .../uniform_buffers/gs-nested-struct.shader_test   |  83 +++++
> >  .../uniform_buffers/vs-array-copy.shader_test      |  51 +++
> >  .../uniform_buffers/vs-dmat4-row-major.shader_test |  44 +++
> >  .../uniform_buffers/vs-dmat4.shader_test           |  44 +++
> >  .../vs-double-array-const-index.shader_test        |  47 +++
> >  .../vs-double-array-variable-index.shader_test     |  54 ++++
> >  .../vs-double-bool-double.shader_test              |  47 +++
> >  ...ouble-uniform-array-direct-indirect.shader_test |  48 +++
> >  .../vs-doubles-float-mixed.shader_test             |  50 +++
> >  .../uniform_buffers/vs-doubles.shader_test         |  49 +++
> >  ...dvec4-uniform-array-direct-indirect.shader_test |  48 +++
> >  .../uniform_buffers/vs-nested-struct.shader_test   |  67 ++++
> >  74 files changed, 5253 insertions(+), 411 deletions(-)
> >  create mode 100644 generated_tests/gen_inout_fp64.py
> >  create mode 100644
> > generated_tests/templates/gen_inout_fp64/template.frag.mako
> >  create mode 100644
> > generated_tests/templates/gen_inout_fp64/template.vert.mako
> >  rename tests/spec/arb_gpu_shader_fp64/execution/vs-out-fs-in-
> > double-
> > 2.shader_test => generated_tests/templates/gen_inout_fp64/vs-out-
> > fs-
> > in_template.mako (56%)
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/execution/double-
> > suffix-value.shader_test
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/fs-
> > getuniformdv.c
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/fs-
> > isinf-dvec.shader_test
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/fs-
> > isnan-dvec.shader_test
> >  delete mode 100644
> > tests/spec/arb_gpu_shader_fp64/execution/getuniformdv.c
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/gs-
> > getuniformdv.c
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/gs-
> > isinf-dvec.shader_test
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/gs-
> > isnan-dvec.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/execution/uniform-
> > invalid-operation.c
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/vs-
> > constructors.shader_test
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/vs-
> > decrement-dvec.shader_test
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/vs-
> > getuniformdv.c
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/vs-
> > increment-dvec.shader_test
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/vs-
> > isinf-dvec.shader_test
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/vs-
> > isnan-dvec.shader_test
> >  delete mode 100644 tests/spec/arb_gpu_shader_fp64/execution/vs-
> > out-
> > fs-in-double.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/preprocessor/define.geom
> >  delete mode 100644 tests/spec/arb_gpu_shader_fp64/preprocessor/fs-
> > output-double.frag
> >  delete mode 100644 tests/spec/arb_gpu_shader_fp64/preprocessor/vs-
> > input-double.vert
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/shader_storage/CMakeLists.gl.txt
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/shader_storage/CMakeLists.txt
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/shader_storage/layout-std140-fp64-
> > mixed-shader.c
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/shader_storage/layout-std140-fp64-
> > shader.c
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/shader_storage/layout-std430-fp64-
> > mixed-shader.c
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/shader_storage/layout-std430-fp64-
> > shader.c
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-array-
> > copy.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-dmat4-row-
> > major.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-dmat4.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-double-array-
> > const-
> > index.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-double-array-
> > variable-index.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-double-bool-
> > double.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-double-uniform-
> > array-direct-indirect.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-doubles-float-
> > mixed.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-
> > doubles.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-dvec4-uniform-
> > array-direct-indirect.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-nested-
> > struct.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-ubo-direct-
> > 1.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-ubo-
> > load.indirect.1.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-ubo-
> > load.indirect.2.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-ubo-
> > load.indirect.3.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/fs-ubo-
> > load.indirect.4.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-array-
> > copy.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-dmat4-row-
> > major.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-dmat4.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-double-array-
> > const-
> > index.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-double-array-
> > variable-index.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-double-bool-
> > double.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-double-uniform-
> > array-direct-indirect.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-doubles-float-
> > mixed.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-dvec4-uniform-
> > array-direct-indirect.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/gs-nested-
> > struct.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-array-
> > copy.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-dmat4-row-
> > major.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-dmat4.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-double-array-
> > const-
> > index.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-double-array-
> > variable-index.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-double-bool-
> > double.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-double-uniform-
> > array-direct-indirect.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-doubles-float-
> > mixed.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-
> > doubles.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-dvec4-uniform-
> > array-direct-indirect.shader_test
> >  create mode 100644
> > tests/spec/arb_gpu_shader_fp64/uniform_buffers/vs-nested-
> > struct.shader_test
> > 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-- 
Br,

Andres

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160418/644c5b2a/attachment.sig>

More information about the Piglit mailing list