[Piglit] [PATCH] glx_arb_sync_control: Add timeout
martin.peres at linux.intel.com
Mon Apr 18 17:15:41 UTC 2016
On 18/04/16 13:22, Marta Lofstedt wrote:
> From: Marta Lofstedt <marta.lofstedt at intel.com>
> The glx_arb_sync_control piglit tests should fail after a
> timeout expired, instead of not terminating.
> Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
All the files in tests/spec/glx_oml_sync_control/ already have this
timeout ... except one, waitformsc.c. Since each test may have a
different run time, I would rather want to keep it that way, to avoid
surprises. How about adding the timeout in waitformsc.c:52?
Other than that, the commit message is a bit strange though. How about this?
glx_arb_sync_control/wait_for_msc: Add a missing timeout
This test requests via GLX to wait until a certain vertical retrace
event (based on the Media Stream Counter, AKA MSC) before being
unblocked by the X-Server. Since there can be bugs in the
implementation, it is possible for the test to hang. Re-enforcing this
idea is that all the other glx_arb_sync_control tests already have a
This change adds a timeout to guard against this case and report a failure.
More information about the Piglit