[Piglit] [PATCH] astc_sliced_3d: Remove extra block_dims increment.

Anuj Phogat anuj.phogat at gmail.com
Tue Aug 9 17:20:25 UTC 2016


On Mon, Aug 8, 2016 at 5:08 PM, Vinson Lee <vlee at freedesktop.org> wrote:
> Fix for-loop-analysis warning.
>
> khr_compressed_astc-sliced-3d-miptree.c:313:3: warning: variable 'block_dims' is incremented both in the loop header
>       and in the loop body [-Wfor-loop-analysis]
>                 block_dims++;
>                 ^
> khr_compressed_astc-sliced-3d-miptree.c:277:50: note: incremented here
>         for ( ; block_dims < ARRAY_SIZE(block_dim_str); block_dims++) {
>                                                         ^
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  .../khr_texture_compression_astc/khr_compressed_astc-sliced-3d-miptree.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-sliced-3d-miptree.c b/tests/spec/khr_texture_compression_astc/khr_compressed_astc-sliced-3d-miptree.c
> index cb884e98bceb..3926db785511 100644
> --- a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-sliced-3d-miptree.c
> +++ b/tests/spec/khr_texture_compression_astc/khr_compressed_astc-sliced-3d-miptree.c
> @@ -310,7 +310,6 @@ test_miptrees(void* input_type)
>                 if (!check_error)
>                         glDeleteTextures(1, &tex_decompressed);
>
> -               block_dims++;
>         }
>         return PIGLIT_PASS;
>  }
> --
> 2.7.4
>
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the Piglit mailing list