[Piglit] [PATCH] framework: fix binary assignment for shader_runner

Michel Dänzer michel at daenzer.net
Wed Aug 10 03:41:00 UTC 2016


On 10/08/16 03:42 AM, Dylan Baker wrote:
> Currently the python layer tries to dispatch shader_tests to the right
> binary (gles2, gles3 or gl). But the implementation is pretty dumb. It
> basically assumes either >= or == are the only operators used, and makes
> wrong assignments for < or <=, which are allowed. Is also only
> understands 2.0 and 3.0 as GLES versions, which is problematic.
> 
> This version uses the closes equivalent of a match statement that python
> has, to try to pick the right GLES version, otherwise it uses the GL
> version. It also shares this picking mechanism with the Fast Skip
> mechanism, so they always have the same result.
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>

Tested-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the Piglit mailing list