[Piglit] [PATCH 1/2] glslparsertest: Added some few more struct construction tests

Dylan Baker dylan at pnwbakers.com
Thu Aug 11 17:43:33 UTC 2016

Quoting Timothy Arceri (2016-08-08 20:14:31)
> On Fri, 2016-08-05 at 17:43 +0300, Andres Gomez wrote:
> > This set focus on checking invalid structs construction.
> > Specifically,
> > adds a test to check that only implicit conversions are perform and
> > vector conversions of the type vec3 to vec2 through dropping the z
> > component are not allowed.
> IMO we should try to avoid adding more tests to these directories.
> I would much rather these be added to tests/spec/glsl-
> 1.20/compiler/constructor/
> I would then name them struct-1.vert .. struct-N.vert
> It's up to you if you want to move/rename the existing contructor tests
> but eventually I think this is something we should do.

IIRC Brian had requested that the whole folder be moved in one go rather
than piecemeal to ease tracking regressions (the same for shaders/ and
other non-sorted folders). And if we do it in one big go we can actually
have the python framework rename the tests for us, making it seamless.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160811/0ddbd047/attachment.sig>

More information about the Piglit mailing list