[Piglit] [PATCH] Fix TCS input array length in tcs-input-read-nonconst* tests.

Francisco Jerez currojerez at riseup.net
Wed Aug 31 19:31:14 UTC 2016


Kenneth Graunke <kenneth at whitecape.org> writes:

> According to the ARB_tessellation_shader spec,
>
>    "Declaring an array size is optional.  If no size is specified, it
>     will be taken from the implementation-dependent maximum patch size
>     (gl_MaxPatchVertices).  If a size is specified, it must match the
>     maximum patch size; otherwise, a compile or link error will occur."
>
> Just drop the explicit array size.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>  .../execution/tcs-input-read-nonconst-interface.shader_test             | 2 +-
>  .../execution/tcs-input-read-nonconst.shader_test                       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/spec/arb_tessellation_shader/execution/tcs-input-read-nonconst-interface.shader_test b/tests/spec/arb_tessellation_shader/execution/tcs-input-read-nonconst-interface.shader_test
> index c83e6fb..f44c528 100644
> --- a/tests/spec/arb_tessellation_shader/execution/tcs-input-read-nonconst-interface.shader_test
> +++ b/tests/spec/arb_tessellation_shader/execution/tcs-input-read-nonconst-interface.shader_test
> @@ -23,7 +23,7 @@ void main()
>  
>  in block {
>  	float v;
> -} verts[2];
> +} verts[];
>  layout(vertices = 1) out;
>  
>  void main()
> diff --git a/tests/spec/arb_tessellation_shader/execution/tcs-input-read-nonconst.shader_test b/tests/spec/arb_tessellation_shader/execution/tcs-input-read-nonconst.shader_test
> index 2e3d1ff..591c9f1 100644
> --- a/tests/spec/arb_tessellation_shader/execution/tcs-input-read-nonconst.shader_test
> +++ b/tests/spec/arb_tessellation_shader/execution/tcs-input-read-nonconst.shader_test
> @@ -19,7 +19,7 @@ void main()
>  #version 150
>  #extension GL_ARB_tessellation_shader : require
>  
> -in float v[2];
> +in float v[];
>  layout(vertices = 1) out;
>  
>  void main()
> -- 
> 2.9.3
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160831/2ff022de/attachment.sig>


More information about the Piglit mailing list