[Piglit] [PATCH 2/2] general: Add a scissored depth clear test that uses negative x, y scissors.

Brian Paul brianp at vmware.com
Wed Aug 31 20:37:23 UTC 2016


On 08/31/2016 02:05 PM, Matt Turner wrote:
> ---
>   tests/general/CMakeLists.gl.txt                 |   1 +
>   tests/general/scissor-depth-clear-negative-xy.c | 104 ++++++++++++++++++++++++

Hi Matt,

The test look OK to me, but I wonder if this could go into 
tests/spec/gl-1.0/ instead of general/ ?

Someday I'd like to see all the tests in general/ get moved somewhere 
under tests/spec/

-Brian


>   2 files changed, 105 insertions(+)
>   create mode 100644 tests/general/scissor-depth-clear-negative-xy.c
>
> diff --git a/tests/general/CMakeLists.gl.txt b/tests/general/CMakeLists.gl.txt
> index 3a46fb0..a5badb9 100644
> --- a/tests/general/CMakeLists.gl.txt
> +++ b/tests/general/CMakeLists.gl.txt
> @@ -103,6 +103,7 @@ piglit_add_executable (scissor-bitmap scissor-bitmap.c)
>   piglit_add_executable (scissor-clear scissor-clear.c)
>   piglit_add_executable (scissor-copypixels scissor-copypixels.c)
>   piglit_add_executable (scissor-depth-clear scissor-depth-clear.c)
> +piglit_add_executable (scissor-depth-clear-negative-xy scissor-depth-clear-negative-xy.c)
>   piglit_add_executable (scissor-many scissor-many.c)
>   piglit_add_executable (scissor-offscreen scissor-offscreen.c)
>   piglit_add_executable (scissor-polygon scissor-polygon.c)
> diff --git a/tests/general/scissor-depth-clear-negative-xy.c b/tests/general/scissor-depth-clear-negative-xy.c
> new file mode 100644
> index 0000000..47202ca
> --- /dev/null
> +++ b/tests/general/scissor-depth-clear-negative-xy.c
> @@ -0,0 +1,104 @@
> +/*
> + * Copyright © 2009, 2016 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + *    Eric Anholt <eric at anholt.net>
> + *    Matt Turner <mattst88 at gmail.com>
> + *
> + */
> +
> +/** @file scissor-depth-clear-negative-xy.c
> + *
> + * Tests that glScissor properly affects glClear(GL_DEPTH_BUFFER_BIT) when
> + * x or y is negative.
> + */
> +
> +#include "piglit-util-gl.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +	config.supports_gl_compat_version = 10;
> +
> +	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DEPTH | PIGLIT_GL_VISUAL_STENCIL;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> +	GLboolean pass = GL_TRUE;
> +	static float green[] = {0.0, 1.0, 0.0, 0.0};
> +	static float blue[]  = {0.0, 0.0, 1.0, 0.0};
> +
> +	/* whole window green -- depth fail will be this. */
> +	glClearColor(0.0, 1.0, 0.0, 0.0);
> +	glClear(GL_COLOR_BUFFER_BIT);
> +
> +	/* Clear depth to 0 (fail) */
> +	glClearDepth(0.0);
> +	glClear(GL_DEPTH_BUFFER_BIT);
> +
> +	/* Clear depth quad the size of the fb at -16, -16 to be drawn blue. */
> +	glEnable(GL_SCISSOR_TEST);
> +	glScissor(-16, -16, piglit_width, piglit_height);
> +	glClearDepth(1.0);
> +	glClear(GL_DEPTH_BUFFER_BIT);
> +
> +	/* Now draw a quad midway between 0.0 and 1.0 depth so only that
> +	 * scissored depth clear will get rasterized.
> +	 */
> +	glEnable(GL_DEPTH_TEST);
> +	glDisable(GL_SCISSOR_TEST);
> +	glDepthFunc(GL_LESS);
> +	glColor4fv(blue);
> +	piglit_draw_rect(0, 0, piglit_width, piglit_height);
> +
> +	pass &= piglit_probe_rect_rgb(0, 0, piglit_width - 16, piglit_height - 16, blue);
> +
> +	pass &= piglit_probe_rect_rgb(piglit_width - 16, 0, 16, piglit_height, green);
> +	pass &= piglit_probe_rect_rgb(0, piglit_height - 16, piglit_width - 16, 16, green);
> +
> +	piglit_present_results();
> +
> +	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
> +}
> +
> +
> +static void reshape(int width, int height)
> +{
> +	piglit_width = width;
> +	piglit_height = height;
> +
> +	glViewport(0, 0, width, height);
> +	glMatrixMode(GL_PROJECTION);
> +	glLoadIdentity();
> +
> +	glOrtho(0.0, width, 0.0, height, -1.0, 1.0);
> +	glMatrixMode(GL_MODELVIEW);
> +	glLoadIdentity();
> +}
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> +	reshape(piglit_width, piglit_height);
> +}
>



More information about the Piglit mailing list