[Piglit] [PATCH] tests: fix requirements for ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag

Ilia Mirkin imirkin at alum.mit.edu
Wed Aug 31 21:45:15 UTC 2016


GL_ARB_texture_multisample should become

"GL_OES_texture_storage_multisample_2d_array"

in both the require_extensions block as well as the #extension line.

On Wed, Aug 31, 2016 at 5:43 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Then the test is buggy... GL_ARB_texture_multisample isn't a valid ext in ES...
>
> On Wed, Aug 31, 2016 at 5:06 PM, Dylan Baker <dylan at pnwbakers.com> wrote:
>> This has a #extension requirement that isn't in the requirements block
>> and causes the test to fail when it should skip.
>>
>> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
>> cc: Ian Romanick <ian.d.romanick at intel.com>
>> ---
>>  .../glsl-es-3.10/compiler/all-functions.frag                            | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag b/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag
>> index c538aaf..592a3ae 100644
>> --- a/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag
>> +++ b/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag
>> @@ -1,7 +1,7 @@
>>  // [config]
>>  // expect_result: pass
>>  // glsl_version: 3.10
>> -// require_extensions: GL_EXT_shader_samples_identical
>> +// require_extensions: GL_EXT_shader_samples_identical GL_ARB_texture_multisample
>>  // [end config]
>>
>>  #version 310 es
>> --
>> 2.9.3
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list