[Piglit] [PATCH 06/10] cl: Add test for clz

Matt Arsenault arsenm2 at gmail.com
Tue Dec 6 19:02:11 UTC 2016


> On Dec 5, 2016, at 12:14, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> 
> On Mon, 2016-12-05 at 09:48 -0800, arsenm2 at gmail.com <mailto:arsenm2 at gmail.com> wrote:
>> From: Matt Arsenault <arsenm2 at gmail.com>
>> 
>> ---
>> tests/cl/program/execute/clz.cl | 389 ++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 389 insertions(+)
>> create mode 100644 tests/cl/program/execute/clz.cl
>> 
>> diff --git a/tests/cl/program/execute/clz.cl b/tests/cl/program/execute/clz.cl
>> new file mode 100644
>> index 0000000..06ba0e3
>> --- /dev/null
>> +++ b/tests/cl/program/execute/clz.cl
>> @@ -0,0 +1,389 @@
>> +/*!
>> +
>> +[config]
>> +name: clz
>> +clc_version_min: 10
> 
> there already is a generated clz test, what's wrong with adding
> testcases there?
> 
> Jan


I looked at this briefly and it looks like it only is testing the builtin function over various ranges. This is more targeted for optimizations involving clz rather than just the raw function itself, so maybe it should be renamed. It test combines like folding compare + select with 0 input argument into the behavior of v_ffbh_u32. I’m not sure this would fit in easily with the simple function tests

-Matt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161206/424cd3c0/attachment.html>


More information about the Piglit mailing list