[Piglit] [PATCH 02/10] cl: Add sign_extend_inreg test

[Jan Vesely]

On Tue, 2016-12-06 at 10:55 -0800, Matt Arsenault wrote:
> > On Dec 5, 2016, at 13:20, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> > 
> > On Mon, 2016-12-05 at 09:48 -0800, arsenm2 at gmail.com <mailto:arsenm2 at gmail.com> wrote:
> > > From: Matt Arsenault <arsenm2 at gmail.com <mailto:arsenm2 at gmail.com>>
> > > 
> > > ---
> > > tests/cl/program/execute/sign_extend_inreg.cl | 387 ++++++++++++++++++++++++++
> > > 1 file changed, 387 insertions(+)
> > > create mode 100644 tests/cl/program/execute/sign_extend_inreg.cl
> > 
> > this looks very GCN specific, the name should IMO indicate it.
> 
> It’s completely a completely generic test, just the testcases are
> intended to stress the important cases for GCN

there is no sign extent CL operation, nor sign extend inreg. CL
implementations are not required to have SGPR registers. Almost all of
the tests in this series are GCN specific especially with the names
like v_* and s_*.

I'm not against GCN specific test cases, I'm just saying that it should
be marked as such. Just like "r600 create release buffer bug", the test
is generic (runs and passes on other platforms), but tests r600
specific bug/behaviour. It would also make it easier to use regexp to
select/skip only these specific tests.

Jan

> 
> > 
> > 
> > why 14 different arguments? does scalarization not work transitively on
> > global pointers?
> 
> 
> This is the most reliable way to get an SGPR value of the correct
> type. I could change it to a uniformly indexed constant pointer (but
> even that may someday only be an optimization that may not always
> happen)
> 
> > 
> > > +                                    int shift0)
> > > +{
> > > +    long args[] =
> > > +        {
> > > +            a0, a1, a2, a3,
> > > +            a4, a5, a6, a7,
> > > +            a8, a9, a10, a11,
> > > +            a12, a13
> > > +        };
> > 
> > I assume the private copy is just to have an array and use for loop?
> > 
> 
> Yes
> 
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161206/812340bc/attachment.sig>